drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dsbos <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3566: Fix: PreparedStatement.executeQuer...
Date Fri, 04 Sep 2015 00:10:57 GMT
Github user dsbos commented on a diff in the pull request:

    https://github.com/apache/drill/pull/143#discussion_r38710996
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
    @@ -1334,8 +1335,6 @@ public String getQueryId() throws SQLException {
     
       @Override
       protected DrillResultSetImpl execute() throws SQLException{
    -    DrillConnectionImpl connection = (DrillConnectionImpl) statement.getConnection();
    -
         connection.getClient().runQuery(QueryType.SQL, this.prepareResult.getSql(),
    --- End diff --
    
    I don't know why the code was like that.  (Maybe to be symmetric with connection.getDriver(),
or maybe from before client was kept?)
    
    Eliminated redundant call to getClient().


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message