drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adeneche <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3566: Fix: PreparedStatement.executeQuer...
Date Thu, 03 Sep 2015 22:50:52 GMT
Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/143#discussion_r38705830
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
    @@ -850,9 +851,9 @@ public void moveToCurrentRow() throws SQLException {
       }
     
       @Override
    -  public DrillStatementImpl getStatement() {
    +  public AvaticaStatement getStatement() {
    --- End diff --
    
    Any specific reason to have this method override it's parent implementation ? it's basically
doing the same thing 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message