drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dsbos <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3661: Edit JDBC doc. for clarity, more c...
Date Wed, 02 Sep 2015 17:13:33 GMT
Github user dsbos commented on a diff in the pull request:

    https://github.com/apache/drill/pull/119#discussion_r38558416
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ---
    @@ -66,17 +69,18 @@
       private boolean afterFirstBatch = false;
     
       /**
    -   * Whether the next call to this.next() should just return {@code true} rather
    -   * than calling nextRowInternally() to try to advance to the next
    -   * record.
    +   * Whether the next call to {@code this.}{@link #next()} should just return
    +   * {@code true} rather than calling {@link #nextRowInternally()} to try to
    +   * advance to the next record.
        * <p>
    -   *   Currently, can be true only for first call to next().
    +   *   Currently, can be true only for first call to {@link #next()}.
        * </p>
        * <p>
    -   *   (Relates to loadInitialSchema()'s calling nextRowInternally()
    +   *   (Relates to {@link #loadInitialSchema()}'s calling nextRowInternally()
    --- End diff --
    
    Frequently, for second and later references in the same paragraph or adjacent paragraphs,
I avoid making those later references links, since having more links can make the text less
readable.
    
    However, since here I already have multiple links to next(), I did make that nextRowInternally()
a link (and added a missing {@code...} for "Statement.execute...(...)").


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message