drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mehant <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3535: Add support for Drop Table
Date Wed, 02 Sep 2015 15:34:01 GMT
Github user mehant commented on a diff in the pull request:

    https://github.com/apache/drill/pull/140#discussion_r38546769
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
---
    @@ -104,6 +107,9 @@ public WorkspaceSchemaFactory(DrillConfig drillConfig, FileSystemPlugin
plugin,
           final FormatMatcher fallbackMatcher = new BasicFormatMatcher(formatPlugin,
               ImmutableList.of(Pattern.compile(".*")), ImmutableList.<MagicString>of());
           fileMatchers.add(fallbackMatcher);
    +      dropFileMatchers = fileMatchers.subList(0, fileMatchers.size() - 1);
    --- End diff --
    
    The matchers are the same except for the pattern associated with defaultInputFormat. Because
the pattern associated with defaultInputFormat is .* and we don't want to match and delete
on this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message