drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3535: Add support for Drop Table
Date Tue, 01 Sep 2015 05:18:26 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/140#discussion_r38386336
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/BasicFormatMatcher.java
---
    @@ -72,7 +72,7 @@ public boolean supportDirectoryReads() {
     
       @Override
       public FormatSelection isReadable(DrillFileSystem fs, FileSelection selection) throws
IOException {
    -    if (isReadable(fs, selection.getFirstPath(fs))) {
    +    if (isFileReadable(fs, selection.getFirstPath(fs))) {
    --- End diff --
    
    Why did you change the name here?  If I recall correctly, the Parquet format matcher doesn't
necessarily need to read a file and can match at the directory level.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message