drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3535: Add support for Drop Table
Date Tue, 01 Sep 2015 05:17:32 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/140#discussion_r38386305
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
---
    @@ -321,8 +327,101 @@ public DrillTable create(String key) {
           return null;
         }
     
    +    private FormatMatcher findMatcher(FileStatus file) {
    +      FormatMatcher matcher = null;
    +      try {
    +        for (FormatMatcher m : dropFileMatchers) {
    +          if (m.isFileReadable(fs, file)) {
    +            return m;
    +          }
    +        }
    +      } catch (IOException e) {
    +        logger.debug("Failed to find format matcher for file: %s", file, e);
    +      }
    +      return matcher;
    +    }
    +
         @Override
         public void destroy(DrillTable value) {
         }
    +
    +    /**
    +     * Check if the table contains homogenenous files that can be read by Drill. Eg:
parquet, json csv etc.
    +     * However if it contains more than one of these formats or a totally different file
format that Drill cannot
    +     * understand then we will raise an exception.
    +     * @param key
    +     * @return
    +     * @throws IOException
    +     */
    +    private boolean isHomogeneous(String key) throws IOException {
    --- End diff --
    
    Why would we only check isHomogeneous for drop and not for query?  Thoughts here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message