Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4C26918363 for ; Mon, 17 Aug 2015 16:54:55 +0000 (UTC) Received: (qmail 64654 invoked by uid 500); 17 Aug 2015 16:54:55 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 64604 invoked by uid 500); 17 Aug 2015 16:54:55 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 64593 invoked by uid 500); 17 Aug 2015 16:54:54 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 64588 invoked by uid 99); 17 Aug 2015 16:54:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Aug 2015 16:54:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D417A1DBF2B; Mon, 17 Aug 2015 16:54:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2158921643269456679==" MIME-Version: 1.0 Subject: Re: Review Request 37515: DRILL-3657: Wrong result with SUM(1) window function when multiple partitions are present From: "Sean Hsuan-Yi Chu" To: "Aman Sinha" Cc: "Sean Hsuan-Yi Chu" , "drill" Date: Mon, 17 Aug 2015 16:54:51 -0000 Message-ID: <20150817165451.23957.19106@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sean Hsuan-Yi Chu" X-ReviewGroup: drill-git X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37515/ X-Sender: "Sean Hsuan-Yi Chu" References: <20150817041139.2928.70686@reviews.apache.org> In-Reply-To: <20150817041139.2928.70686@reviews.apache.org> Reply-To: "Sean Hsuan-Yi Chu" X-ReviewRequest-Repository: drill-git --===============2158921643269456679== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37515/ ----------------------------------------------------------- (Updated Aug. 17, 2015, 4:54 p.m.) Review request for drill and Aman Sinha. Changes ------- Modified unit test Bugs: DRILL-3657 https://issues.apache.org/jira/browse/DRILL-3657 Repository: drill-git Description ------- When constants are referred in Window Prel, ensure the indices are shifted properly Diffs (updated) ----- exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrule.java f6d2b67 exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java 9e09106 Diff: https://reviews.apache.org/r/37515/diff/ Testing ------- All required Thanks, Sean Hsuan-Yi Chu --===============2158921643269456679==--