drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3724 - added javadoc for core classes fo...
Date Sun, 30 Aug 2015 15:47:45 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/139#discussion_r38272883
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyFormatPlugin.java
---
    @@ -115,6 +115,10 @@ public boolean isBlockSplittable() {
         return blockSplittable;
       }
     
    +  /** Whether or not this format could also be in a compression container (for example:
csv.gz versus csv).  
    +   * This is an external compression container that would be handled outside of the format
code. 
    +   * This is an internal compression scheme, not supported by Parquet.
    --- End diff --
    
    A little unclear.  Maybe "If this format uses its own internal compression scheme, such
as Parquet does, then this should return false."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message