drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Hsuan-Yi Chu" <hsua...@usc.edu>
Subject Re: Review Request 37893: DRILL-3718: TSV reader fails when "" appears
Date Sat, 29 Aug 2015 03:10:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37893/
-----------------------------------------------------------

(Updated Aug. 29, 2015, 3:10 a.m.)


Review request for drill, Jacques Nadeau and Mehant Baid.


Changes
-------

A new patch without using '\t'; This new version passed all the test


Bugs: DRILL-3718
    https://issues.apache.org/jira/browse/DRILL-3718


Repository: drill-git


Description
-------

For TSV files, if the TextReader reads a double quote, it would keep scanning until it gets
the second double quote.

However, even getting the second double quote, the current reader will keep going in order
to trim the space (i.e., ' '). 

In tsv, there is no need to trim '\t' (tab), which is used to separate fields.


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/TextReader.java
3899509 
  exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 6b74ecf 
  exec/java-exec/src/test/resources/store/text/WithQuote.tsv PRE-CREATION 

Diff: https://reviews.apache.org/r/37893/diff/


Testing
-------

All


Thanks,

Sean Hsuan-Yi Chu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message