drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mehant Baid" <baid.meh...@gmail.com>
Subject Re: Review Request 37896: DRILL-3719: Adding negative sign in front of EXTRACT triggers Assertion Error
Date Fri, 28 Aug 2015 23:09:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37896/#review96948
-----------------------------------------------------------

Ship it!


LGTM.

- Mehant Baid


On Aug. 28, 2015, 11:03 p.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37896/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 11:03 p.m.)
> 
> 
> Review request for drill, Aman Sinha, Jinfeng Ni, and Mehant Baid.
> 
> 
> Bugs: DRILL-3719
>     https://issues.apache.org/jira/browse/DRILL-3719
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Expand -expression as -1 * expression in DrillOptiq
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java
11b9c9e 
>   exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 6b74ecf 
> 
> Diff: https://reviews.apache.org/r/37896/diff/
> 
> 
> Testing
> -------
> 
> all passed
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message