drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaltekruse <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3715 Support all encoded vector types fo...
Date Wed, 26 Aug 2015 23:21:23 GMT
Github user jaltekruse commented on the pull request:

    We should have a plan verification test to make sure that this change actually has the
desired effect. This should be able to execute fine without your change as well, but the plan
will have and unnecessary SelectionVectorRemover in it today. You can see examples of plan
verification tests in /Users/jaltekruse/drill/exec/java-exec/src/test/java/org/apache/drill/TestCTASPartitionFilter.java
and other subclasses of PlanTestBase

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message