drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jinfeng Ni" <...@maprtech.com>
Subject Review Request 37721: DRILL-3542: Rebase Drill on top of Calcite 1.4.0
Date Mon, 24 Aug 2015 17:56:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37721/
-----------------------------------------------------------

Review request for drill and Aman Sinha.


Repository: drill-git


Description
-------

Drill uses Calcite as its SQL parser, planner, optimizer. Currently, Drill uses a forked version
of Calcite, on top of Calcite 1.1.0 release. Since the latest of Calcite release is 1.4.0
(in voting process at this moment), Drill should move its forked version on top of Calcite
1.4.0 release, to leverage the new features developed in Calcite, as well as many bug fixes.

In this patch, we are going to rebase drill's forked Calcite onto Calcite release 1.4.0. This
is similar to what we have done in Drill-1384, which moves Drill's forked version from 0.9
to 1.1.0.

During the rebasing process, we have identified around 10 categories of regression failures.
Those failures are addressed either in the rebased forking Calcite libary, or in Drill side.


We will modify the relese number to 1.4.0-drill-rx, once the patch has gone through the review
and ready for merge to Drill master branch. 

As a follow-up task, we are going to push couple of patches to Calcite master branch in the
next release, aiming to get rid of the forked version some day.

The forked Calcite branch is currently hosted here:

https://github.com/jinfengni/incubator-optiq/tree/DrillCalcite1.4.0


Diffs
-----

  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/HiveUDFOperator.java
988060c 
  exec/java-exec/src/main/codegen/data/Parser.tdd 358b75e 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java 1dc9349

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjIntoScan.java
950cd87 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java 4307757

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/Checker.java 42aa728 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java
a53c242 
  exec/jdbc-all/pom.xml 0e1f85d 
  pom.xml a4b22d7 

Diff: https://reviews.apache.org/r/37721/diff/


Testing
-------

JUnit test.

Pre-commit regression suite.


Thanks,

Jinfeng Ni


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message