drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aman Sinha" <asi...@maprtech.com>
Subject Re: Review Request 37515: DRILL-3657: Wrong result with SUM(1) window function when multiple partitions are present
Date Mon, 17 Aug 2015 16:08:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37515/#review95592
-----------------------------------------------------------



exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrule.java (line
158)
<https://reviews.apache.org/r/37515/#comment150628>

    Would this work if there was non-window-agg functions present...such as RANK() (in combination
with window aggs) ?


- Aman Sinha


On Aug. 17, 2015, 4:11 a.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37515/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2015, 4:11 a.m.)
> 
> 
> Review request for drill and Aman Sinha.
> 
> 
> Bugs: DRILL-3657
>     https://issues.apache.org/jira/browse/DRILL-3657
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> When constants are referred in Window Prel, ensure the indices are shifted properly
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrule.java
f6d2b67 
>   exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java 9e09106

> 
> Diff: https://reviews.apache.org/r/37515/diff/
> 
> 
> Testing
> -------
> 
> All required
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message