drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aman Sinha" <asi...@maprtech.com>
Subject Re: Review Request 37339: DRILL-3574: Empty Over Clause should trigger Union-Exchange to be added below
Date Tue, 11 Aug 2015 23:33:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37339/#review95026
-----------------------------------------------------------



exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/DrillDistributionTrait.java
(line 49)
<https://reviews.apache.org/r/37339/#comment149800>

    Actually, I did not realize..there is an alternate constructor that allows singleton without
the distribution fields.  Can you try to use that ?


- Aman Sinha


On Aug. 11, 2015, 4:54 p.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37339/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2015, 4:54 p.m.)
> 
> 
> Review request for drill and Aman Sinha.
> 
> 
> Bugs: DRILL-3574
>     https://issues.apache.org/jira/browse/DRILL-3574
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> For the empty Over-Clause, make DrillDistributionTrait to be as SINGLETON
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/DrillDistributionTrait.java
c1e241d 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrule.java
034fd47 
>   exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java ce5a477

> 
> Diff: https://reviews.apache.org/r/37339/diff/
> 
> 
> Testing
> -------
> 
> All required
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message