drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaltekruse <...@git.apache.org>
Subject [GitHub] drill pull request:
Date Tue, 04 Aug 2015 22:46:08 GMT
Github user jaltekruse commented on the pull request:

    https://github.com/apache/drill/commit/5cd991628b79f64b681f1eb18deb5858b4264774#commitcomment-12528842
  
    In common/src/main/java/org/apache/drill/common/config/DrillConfig.java:
    In common/src/main/java/org/apache/drill/common/config/DrillConfig.java on line 68:
    That's a reasonable point, I was just thinking about it from the other direction of avoiding
the clutter where we didn't have demonstrated need for the optimization, but it really isn't
that much clutter and it could make the unit tests a little faster. I can make a small PR
to add it back. I actually forgot to add the "closes PR-#" to these commit messages when I
added them to the merge branch, so there are a few dangling pull requests right now that I
could clean up with another commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message