drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request:
Date Tue, 04 Aug 2015 22:32:52 GMT
Github user jacques-n commented on the pull request:

    https://github.com/apache/drill/commit/5cd991628b79f64b681f1eb18deb5858b4264774#commitcomment-12528627
  
    In common/src/main/java/org/apache/drill/common/config/DrillConfig.java:
    In common/src/main/java/org/apache/drill/common/config/DrillConfig.java on line 68:
    My main thought was that we already suffer from slow startup.  This looks like a non-trivial
chunk of effort.  I'm guessing this call renders a giant JSON blog.  You right that it is
only once (although in testing that is actually once per test).  I'm inclined to use this
type of guarding if it is frequent or if it is non-trivial.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message