drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-2852: Examine the input of a CAST functi...
Date Tue, 04 Aug 2015 01:16:05 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/103#discussion_r36149446
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/FindPartitionConditions.java
---
    @@ -217,8 +218,21 @@ public Void visitCorrelVariable(RexCorrelVariable correlVariable)
{
       }
     
       public Void visitCall(RexCall call) {
    -    // assume PUSH until proven otherwise
    -    analyzeCall(call, PushDirFilter.PUSH);
    +    boolean visited = false;
    +    // examine the input of a CAST function; this could be extended for
    +    // other functions in the future.
    --- End diff --
    
    As the comment indicated, this patch only solves the problem when there is CAST function.
Is there any particular reason why other function is not supported? How much effort do we
need to get other functions work as well?
    
    I could hit the same problem, with the following filter:
    
    where (dir0 - 1 = 1994 and o_totalprice < 40000) or dir0=1996"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message