Return-Path: 
 <dev-return-15369-apmail-drill-dev-archive=drill.apache.org@drill.apache.org>
X-Original-To: apmail-drill-dev-archive@www.apache.org
Delivered-To: apmail-drill-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id EA70B18E30
	for <apmail-drill-dev-archive@www.apache.org>;
 Tue, 28 Jul 2015 21:34:04 +0000 (UTC)
Received: (qmail 26610 invoked by uid 500); 28 Jul 2015 21:34:04 -0000
Delivered-To: apmail-drill-dev-archive@drill.apache.org
Received: (qmail 26557 invoked by uid 500); 28 Jul 2015 21:34:04 -0000
Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@drill.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@drill.apache.org>
List-Post: <mailto:dev@drill.apache.org>
List-Id: <dev.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list dev@drill.apache.org
Received: (qmail 26504 invoked by uid 99); 28 Jul 2015 21:34:04 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Jul 2015 21:34:04 +0000
Date: Tue, 28 Jul 2015 21:34:04 +0000 (UTC)
From: "Daniel Barclay (Drill) (JIRA)" <jira@apache.org>
To: dev@drill.apache.org
Message-ID: <JIRA.12849765.1438119211000.312087.1438119244661@Atlassian.JIRA>
In-Reply-To: <JIRA.12849765.1438119211000@Atlassian.JIRA>
References: <JIRA.12849765.1438119211000@Atlassian.JIRA>
 <JIRA.12849765.1438119211616@arcas>
Subject: [jira] [Created] (DRILL-3570) TestBuilder.baselineRecords(List<Map)
 doesn't handle null well
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394

Daniel Barclay (Drill) created DRILL-3570:
---------------------------------------------

             Summary: TestBuilder.baselineRecords(List<Map) doesn't handle null well
                 Key: DRILL-3570
                 URL: https://issues.apache.org/jira/browse/DRILL-3570
             Project: Apache Drill
          Issue Type: Bug
          Components: Tools, Build & Test
            Reporter: Daniel Barclay (Drill)
            Assignee: Jason Altekruse


TestBuilder.baselineRecords(List<Map>) accepts a call with null (doesn't reject it with a bad-parameter error) but does not accept it as an specification of a baseline (to prevent the "Must provide some kind of baseline, either a baseline file or another query" error).

Either it should reject null (and the parameter documentation should probably have "; not null" added), or when it gets null, it should take that as providing some kind of baseline (maybe a baseline of zero rows (like and empty list), or maybe a don't-care baseline) (and the documentation should reflect that).






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)