Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 468D21872B for ; Mon, 27 Jul 2015 04:38:07 +0000 (UTC) Received: (qmail 36786 invoked by uid 500); 27 Jul 2015 04:38:07 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 36735 invoked by uid 500); 27 Jul 2015 04:38:07 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 36724 invoked by uid 500); 27 Jul 2015 04:38:06 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 36718 invoked by uid 99); 27 Jul 2015 04:38:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Jul 2015 04:38:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 11BCB1CF88E; Mon, 27 Jul 2015 04:38:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5472993928051482672==" MIME-Version: 1.0 Subject: Re: Review Request 36782: DRILL-3537: Empty Json file can potentially result into wrong results From: "Sean Hsuan-Yi Chu" To: "Parth Chandra" , "Hanifi Gunes" Cc: "Sean Hsuan-Yi Chu" , "drill" Date: Mon, 27 Jul 2015 04:38:06 -0000 Message-ID: <20150727043806.28761.27131@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sean Hsuan-Yi Chu" X-ReviewGroup: drill-git X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36782/ X-Sender: "Sean Hsuan-Yi Chu" References: <20150724154706.1578.80826@reviews.apache.org> In-Reply-To: <20150724154706.1578.80826@reviews.apache.org> Reply-To: "Sean Hsuan-Yi Chu" X-ReviewRequest-Repository: drill-git --===============5472993928051482672== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36782/ ----------------------------------------------------------- (Updated July 27, 2015, 4:38 a.m.) Review request for drill, Hanifi Gunes and Parth Chandra. Changes ------- Update the description Bugs: DRILL-3537 https://issues.apache.org/jira/browse/DRILL-3537 Repository: drill-git Description ------- Whe scanning files in ScanBatch, ignore all the empty files before reach a non-empty file Diffs ----- exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java 6bf1280 exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonReader.java 912a5f0 exec/java-exec/src/test/resources/store/json/jsonDirectoryWithEmpyFile/a.json PRE-CREATION exec/java-exec/src/test/resources/store/json/jsonDirectoryWithEmpyFile/b.json PRE-CREATION Diff: https://reviews.apache.org/r/36782/diff/ Testing (updated) ------- Unit, tpch, functional all passed Thanks, Sean Hsuan-Yi Chu --===============5472993928051482672==--