Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A356A18CF7 for ; Wed, 1 Jul 2015 21:21:31 +0000 (UTC) Received: (qmail 41302 invoked by uid 500); 1 Jul 2015 21:21:31 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 41249 invoked by uid 500); 1 Jul 2015 21:21:31 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 41238 invoked by uid 500); 1 Jul 2015 21:21:31 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 41232 invoked by uid 99); 1 Jul 2015 21:21:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jul 2015 21:21:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 40AC9B1CC9; Wed, 1 Jul 2015 21:21:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8500596172780206400==" MIME-Version: 1.0 Subject: Re: Review Request 36103: DRILL-3445: BufferAllocator.buffer() implementations should throw an OutOfMemoryRuntimeException From: "abdelhakim deneche" To: "Chris Westin" , "Hanifi Gunes" Cc: "abdelhakim deneche" , "drill" Date: Wed, 01 Jul 2015 21:21:30 -0000 Message-ID: <20150701212130.13308.4995@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "abdelhakim deneche" X-ReviewGroup: drill-git X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36103/ X-Sender: "abdelhakim deneche" References: <20150701193449.13307.41360@reviews.apache.org> In-Reply-To: <20150701193449.13307.41360@reviews.apache.org> Reply-To: "abdelhakim deneche" X-ReviewRequest-Repository: drill-git --===============8500596172780206400== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36103/ ----------------------------------------------------------- (Updated July 1, 2015, 9:21 p.m.) Review request for drill, Chris Westin and Hanifi Gunes. Bugs: DRILL-3445 https://issues.apache.org/jira/browse/DRILL-3445 Repository: drill-git Description ------- BufferAllocator.buffer(int) implementations throw an OutOfMemoryRuntimeException instead of returning null. Diffs ----- exec/java-exec/src/main/codegen/templates/FixedValueVectors.java 7103a17 exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java 50ae770 exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorAccessibleSerializable.java 016cd92 exec/java-exec/src/main/java/org/apache/drill/exec/memory/BufferAllocator.java 811cceb exec/java-exec/src/main/java/org/apache/drill/exec/memory/TopLevelAllocator.java b4386a4 exec/java-exec/src/main/java/org/apache/drill/exec/record/selection/SelectionVector2.java 7a7c012 exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ProtobufLengthDecoder.java 4e03f11 exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetDirectByteBufferAllocator.java cf30db6 exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java 10bdf07 exec/java-exec/src/main/java/parquet/hadoop/ColumnChunkIncReadStore.java 6337d4c exec/java-exec/src/test/java/org/apache/drill/TestAllocationException.java 051ad4e exec/java-exec/src/test/java/org/apache/drill/exec/memory/TestAllocators.java 74ce225 Diff: https://reviews.apache.org/r/36103/diff/ Testing (updated) ------- unit tests are passing, along with functional and tpch100 Thanks, abdelhakim deneche --===============8500596172780206400==--