drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dsbos <...@git.apache.org>
Subject [GitHub] drill pull request: Enhanced logging and associated code hygiene
Date Wed, 15 Jul 2015 00:08:50 GMT
GitHub user dsbos opened a pull request:

    https://github.com/apache/drill/pull/93

    Enhanced logging and associated code hygiene

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dsbos/incubator-drill bugs/drill-2815-etc-Logging

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/93.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #93
    
----
commit 24390a34e6886d019382f0e0c00cab570a499045
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-07-14T04:02:40Z

    DRILL-2815: Augment PathScanner logging; clean up code.
    
    Added some DEBUG- and TRACE-level log calls.
    Augmented/edited existing log call.
    
    Misc. code hygiene:
    - Added documentation of forResources(...).
    - Renamed to clarify a number of local names.
    - Made logger private.
    - Added "final".
    - Fixed indentation; wrapped some long lines; etc.
    
    Conflicts:
    	common/src/main/java/org/apache/drill/common/util/PathScanner.java

commit e740ac4f7acc022922b5e5eebe209de42c504406
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-07-14T19:11:36Z

    DRILL-3496: Augment logging in DrillConfig and classpath scanning.
    
    Main: Added and augmented logging calls.
    
    Code Hygiene:
    - Added/revised doc. comments, code comments.
    - Renamed some locals.
    - Added "final".
    - Wrapped lines.
    
    Also fixed currentTimeMillis -> Stopwatch in Drillbit.
    
    Conflicts:
    	common/src/main/java/org/apache/drill/common/config/DrillConfig.java

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message