drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3497: Throw UserException#validationErro...
Date Tue, 14 Jul 2015 22:41:52 GMT
GitHub user sudheeshkatkam opened a pull request:

    https://github.com/apache/drill/pull/91

    DRILL-3497: Throw UserException#validationError for errors when modifying options

    Rebased on top of DRILL-2304.
    
    @jaltekruse please review the third commit: 6ec7b32

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sudheeshkatkam/drill DRILL-3497

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/91.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #91
    
----
commit 313c8e3632fa71a5ed5f62baf1146e8c20f80065
Author: Sudheesh Katkam <skatkam@maprtech.com>
Date:   2015-07-14T18:29:56Z

    DRILL-2304: Part 1: Documentation for OptionManagers
    + corrected error message in BaseOptionManager
    + use getAdmin in setOption method

commit f33654c7c539863e56958cc1746eded329b73e61
Author: Sudheesh Katkam <skatkam@maprtech.com>
Date:   2015-07-14T21:54:16Z

    DRILL-2304: Part 2: Manage options with lowercase names

commit 6ec7b326459094a865846b1758e9d4457752af4c
Author: Sudheesh Katkam <skatkam@maprtech.com>
Date:   2015-07-14T22:33:30Z

    DRILL-3497: Throw UserException#validationError instead of SetOptionException and ExpressionParsingException
for options
    
    + Fixed bug in PositiveLongValidator (0 is not positive)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message