drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Deneche A. Hakim (JIRA)" <j...@apache.org>
Subject [jira] [Created] (DRILL-3445) BufferAllocator.buffer() implementations should throw an OutOfMemoryRuntimeException
Date Wed, 01 Jul 2015 14:35:04 GMT
Deneche A. Hakim created DRILL-3445:
---------------------------------------

             Summary: BufferAllocator.buffer() implementations should throw an OutOfMemoryRuntimeException
                 Key: DRILL-3445
                 URL: https://issues.apache.org/jira/browse/DRILL-3445
             Project: Apache Drill
          Issue Type: Bug
          Components: Execution - Data Types, Execution - Relational Operators
    Affects Versions: 1.0.0
            Reporter: Deneche A. Hakim
            Assignee: Deneche A. Hakim
             Fix For: 1.2.0


current implementations of BufferAllocator.buffer() return null if it can't allocate the buffer
because of direct memory or fragment limits., but many places in the code don't actually check
if the buffer is null before trying to access it, this will result in confusing NullPointerException(s)
when we are in fact running out of memory.

We should change the implementations to throw an OutOfMemoryRuntimeException instead. Drill
already handles this exception properly in most cases and displays a proper error message
to the user.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message