drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Barclay <dbarc...@maprtech.com>
Subject dropping qualified names in logger declarations
Date Wed, 22 Jul 2015 01:12:21 GMT
For logger member declarations, can we drop the current pattern of using
qualified names (like this:

   private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(StoragePluginRegistry.class);

) and allow using imports and non-qualified names (as we do for almost
everything else)?


Using qualified names adds a lot of visual noise, and pushes the class
literal farther to the right, making it easier to fail to notice that
it doesn't match the containing class.

Thanks,
Daniel
-- 
Daniel Barclay
MapR Technologies

Mime
View raw message