drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaltekruse <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3313: Eliminate redundant #load methods ...
Date Wed, 29 Jul 2015 20:58:05 GMT
Github user jaltekruse commented on a diff in the pull request:

    https://github.com/apache/drill/pull/81#discussion_r35811005
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/FixedWidthVector.java
---
    @@ -26,21 +25,8 @@
        *
        * @param valueCount   Number of values in the vector.
        */
    -  public void allocateNew(int valueCount);
    -
    -  /**
    -   * Load the records in the provided buffer based on the given number of values.
    -   * @param valueCount Number of values the buffer contains.
    -   * @param buf Incoming buffer.
    -   * @return The number of bytes of the buffer that were consumed.
    -   */
    -  public int load(int valueCount, DrillBuf buf);
    +  void allocateNew(int valueCount);
     
    +  void zeroVector();
     
    -  public abstract Mutator getMutator();
    -
    -  /**
    -   * Zero out the underlying buffer backing this vector.
    --- End diff --
    
    I think this comment should be left in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message