drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaltekruse <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3313: Eliminate redundant #load methods ...
Date Wed, 29 Jul 2015 20:50:39 GMT
Github user jaltekruse commented on a diff in the pull request:

    https://github.com/apache/drill/pull/81#discussion_r35810091
  
    --- Diff: exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java ---
    @@ -119,29 +117,22 @@ public int getVarByteLength(){
       @Override
       public SerializedField getMetadata() {
         return getMetadataBuilder() //
    +             .addChild(offsetVector.getMetadata())
                  .setValueCount(getAccessor().getValueCount()) //
    -             .setVarByteLength(getVarByteLength()) //
    +//             .setVarByteLength(getVarByteLength()) //
    --- End diff --
    
    We should probably at least leave a comment as to why this was here originally and why
it was removed and/or may re-enabled at some point. That or just remove it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message