drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dsbos <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-2818, DRILL-3496: Enhanced logging and a...
Date Mon, 27 Jul 2015 17:00:46 GMT
Github user dsbos commented on a diff in the pull request:

    https://github.com/apache/drill/pull/93#discussion_r35559349
  
    --- Diff: common/src/main/java/org/apache/drill/common/logical/FormatPluginConfigBase.java
---
    @@ -27,11 +27,20 @@
       static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(FormatPluginConfigBase.class);
     
     
    -  public synchronized static Class<?>[] getSubTypes(DrillConfig config){
    -    List<String> packages = config.getStringList(CommonConstants.STORAGE_PLUGIN_CONFIG_SCAN_PACKAGES);
    -    Class<?>[] sec = PathScanner.scanForImplementationsArr(FormatPluginConfig.class,
packages);
    -    logger.debug("Adding Format Plugin Configs including {}", (Object) sec );
    -    return sec;
    +  public synchronized static Class<?>[] getSubTypes(DrillConfig config) {
    +    List<String> packages =
    +        config.getStringList(CommonConstants.STORAGE_PLUGIN_CONFIG_SCAN_PACKAGES);
    +    Class<?>[] pluginClasses =
    +        PathScanner.scanForImplementationsArr(FormatPluginConfig.class, packages);
    +    if (logger.isDebugEnabled()) {
    +      final StringBuilder sb = new StringBuilder();
    --- End diff --
    
    Reduce line count by factoring out part that Joiner could be used for.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message