drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Hsuan-Yi Chu" <hsua...@usc.edu>
Subject Re: Review Request 32248: DRILL-2139: Star is not expanded correctly in "select distinct" query
Date Fri, 24 Jul 2015 15:56:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32248/
-----------------------------------------------------------

(Updated July 24, 2015, 3:56 p.m.)


Review request for drill, Aman Sinha and Jinfeng Ni.


Changes
-------

rebase


Bugs: DRILL-2139
    https://issues.apache.org/jira/browse/DRILL-2139


Repository: drill-git


Description
-------

Expand * at the run time


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/AggregateUtils.java
PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java
a033a8e 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggBatch.java
5a26134 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
4bb1572 
  exec/java-exec/src/test/java/org/apache/drill/TestDistinctStar.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/agg/TestHashAggr.java 3786bfd

  exec/java-exec/src/test/resources/store/text/data/repeatedRows.json PRE-CREATION 
  exec/java-exec/src/test/resources/testframework/testDistinctStar/testSelectDistinct.tsv
PRE-CREATION 
  exec/java-exec/src/test/resources/testframework/testDistinctStar/testSelectDistinctExpression.tsv
PRE-CREATION 
  exec/java-exec/src/test/resources/testframework/testDistinctStar/testSelectDistinctOverJoin.tsv
PRE-CREATION 

Diff: https://reviews.apache.org/r/32248/diff/


Testing
-------

Unit and all QA tests passed.


Thanks,

Sean Hsuan-Yi Chu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message