drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Hsuan-Yi Chu" <hsua...@usc.edu>
Subject Review Request 36782: DRILL-3537: Empty Json file can potentially result into wrong results
Date Fri, 24 Jul 2015 15:47:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36782/
-----------------------------------------------------------

Review request for drill, Hanifi Gunes and Parth Chandra.


Bugs: DRILL-3537
    https://issues.apache.org/jira/browse/DRILL-3537


Repository: drill-git


Description
-------

Whe scanning files in ScanBatch, ignore all the empty files before reach a non-empty file


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java 6bf1280

  exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonReader.java
912a5f0 
  exec/java-exec/src/test/resources/store/json/jsonDirectoryWithEmpyFile/a.json PRE-CREATION

  exec/java-exec/src/test/resources/store/json/jsonDirectoryWithEmpyFile/b.json PRE-CREATION


Diff: https://reviews.apache.org/r/36782/diff/


Testing
-------

Unit, tpch, (functional is down; will run again when it comes back)


Thanks,

Sean Hsuan-Yi Chu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message