drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaltekruse <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-2818, DRILL-3496: Enhanced logging and a...
Date Tue, 21 Jul 2015 17:00:25 GMT
Github user jaltekruse commented on a diff in the pull request:

    https://github.com/apache/drill/pull/93#discussion_r35126587
  
    --- Diff: common/src/main/java/org/apache/drill/common/logical/FormatPluginConfigBase.java
---
    @@ -27,11 +27,20 @@
       static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(FormatPluginConfigBase.class);
     
     
    -  public synchronized static Class<?>[] getSubTypes(DrillConfig config){
    -    List<String> packages = config.getStringList(CommonConstants.STORAGE_PLUGIN_CONFIG_SCAN_PACKAGES);
    -    Class<?>[] sec = PathScanner.scanForImplementationsArr(FormatPluginConfig.class,
packages);
    -    logger.debug("Adding Format Plugin Configs including {}", (Object) sec );
    -    return sec;
    +  public synchronized static Class<?>[] getSubTypes(DrillConfig config) {
    +    List<String> packages =
    +        config.getStringList(CommonConstants.STORAGE_PLUGIN_CONFIG_SCAN_PACKAGES);
    +    Class<?>[] pluginClasses =
    +        PathScanner.scanForImplementationsArr(FormatPluginConfig.class, packages);
    +    if (logger.isDebugEnabled()) {
    +      final StringBuilder sb = new StringBuilder();
    --- End diff --
    
    There believe there are at least packages in common that claim to hold general utilities.
If you can't find a class to put in a utility function, I think it would be fine to create
one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message