drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dsbos <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-2818, DRILL-3496: Enhanced logging and a...
Date Mon, 20 Jul 2015 22:51:28 GMT
Github user dsbos commented on a diff in the pull request:

    https://github.com/apache/drill/pull/93#discussion_r35053589
  
    --- Diff: common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
    @@ -115,19 +124,26 @@ public static DrillConfig forClient() {
        * <p>
        * Configuration values are retrieved as follows:
        * <ul>
    -   * <li>Check a single copy of "drill-override.conf". If multiple copies are on
the classpath, behavior is
    -   * indeterminate.  If a non-null value for overrideFileName is provided, this is utilized
instead of drill-override.conf.</li>
    -   * <li>Check all copies of "drill-module.conf". Loading order is indeterminate.</li>
    -   * <li>Check a single copy of "drill-default.conf". If multiple copies are on
the classpath, behavior is
    -   * indeterminate.</li>
    +   * <li>Check a single copy of "drill-override.conf".  If multiple copies are
    +   *     on the classpath, which copy is read is indeterminate.
    +   *     If a non-null value for overrideFileResourcePathname is provided, this
    +   *     is used instead of "{@code drill-override.conf}".</li>
    +   * <li>Check all copies of "{@code drill-module.conf}".  Loading order is
    +   *     indeterminate.</li>
    +   * <li>Check a single copy of "{@code drill-default.conf}".  If multiple
    +   *     copies are on the classpath, which copy is read is indeterminate.</li>
        * </ul>
        *
        * </p>
    -   *  @param overrideFileName The name of the file to use for override purposes.
    +   * @param overrideFileResourcePathname
    +   *          the classpath resource pathname of the file to use for
    +   *          configuration override purposes; {@code null} specifies to use the
    +   *          default pathname ({@link CommonConstants.CONFIG_OVERRIDE})
    +   *          (<strong>not</strong> to not look for an override file at all)
    --- End diff --
    
    Reworded.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message