drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Smidth Panchamia" <spancha...@maprtech.com>
Subject Re: Review Request 35891: Add support for encoding/decoding of Int to/from OrderedBytes format
Date Mon, 13 Jul 2015 18:44:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35891/
-----------------------------------------------------------

(Updated July 13, 2015, 6:44 p.m.)


Review request for drill and Aditya Kishore.


Changes
-------

Added the JIRA information and drill-git group


Bugs: DRILL-3492
    https://issues.apache.org/jira/browse/DRILL-3492


Repository: drill-git


Description
-------

The implementation of this change has been ported from HBase OrderedBytes class. 
Ref: https://github.com/apache/hbase/blob/master/hbase-common/src/main/java/org/apache/hadoop/hbase/util/OrderedBytes.java


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/Order.java PRE-CREATION

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/OrderedBytesIntConvertFrom.java
PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/OrderedBytesIntConvertTo.java
PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestConvertFunctions.java
a911e29 

Diff: https://reviews.apache.org/r/35891/diff/


Testing
-------

Added 2 unit-tests to TestConvertFunctions based on the input and output from HBase OrderedBytes
class.


Thanks,

Smidth Panchamia


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message