drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cwestin <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-2650: Mark query end time when closing t...
Date Sat, 11 Jul 2015 00:13:32 GMT
Github user cwestin commented on a diff in the pull request:

    https://github.com/apache/drill/pull/80#discussion_r34406507
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java
---
    @@ -695,7 +697,10 @@ public void close() {
           Preconditions.checkState(!isClosed);
           Preconditions.checkState(resultState != null);
     
    -      logger.info("foreman cleaning up.");
    +      // to track how long the query takes
    +      queryManager.markEndTime();
    +
    +      logger.info(queryIdString + ": cleaning up.");
    --- End diff --
    
    .info() seems like it will generate a lot of noise here, should it be .debug()?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message