drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hanifi Gunes" <hanifigu...@gmail.com>
Subject Re: Review Request 36229: Patch for DRILL-1750
Date Thu, 09 Jul 2015 00:35:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36229/#review91030
-----------------------------------------------------------



exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java (line 213)
<https://reviews.apache.org/r/36229/#comment144259>

    I remember a similar problem where vectors in a container have different number of values.
Would it be better to move this logic into VectorContainer#setRecordCount to ensure vectors
are aligned within a container?


- Hanifi Gunes


On July 6, 2015, 11:39 p.m., Steven Phillips wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36229/
> -----------------------------------------------------------
> 
> (Updated July 6, 2015, 11:39 p.m.)
> 
> 
> Review request for drill.
> 
> 
> Bugs: DRILL-1750
>     https://issues.apache.org/jira/browse/DRILL-1750
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> DRILL-1750: Set value count on all outgoing vectors in ScanBatch
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java 6bf1280ae09045a4d73d566c25d624acced6a68d

>   exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java
bb1af9eb2e6ab4950c166b8057680fff175c7a3f 
>   exec/java-exec/src/test/resources/jsoninput/1750/a.json PRE-CREATION 
>   exec/java-exec/src/test/resources/jsoninput/1750/b.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36229/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Steven Phillips
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message