drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Altekruse" <altekruseja...@gmail.com>
Subject Review Request 36292: DRILL-2838: flatten after join failing
Date Wed, 08 Jul 2015 05:44:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36292/
-----------------------------------------------------------

Review request for drill and Hanifi Gunes.


Bugs: DRILL-2838
    https://issues.apache.org/jira/browse/DRILL-2838


Repository: drill-git


Description
-------

This issue was fixed for project recently, it relates to imcomplete schema population. I applied
the same fix to the flatten operator. I tried to get some intial work done on refactoring
to more appropriately share code between flatten and project. This is a bit large in scope,
so I have added a new JIRA to track this https://issues.apache.org/jira/browse/DRILL-3471


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java
491ced3 
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/flatten/TestFlatten.java
39e36eb 
  exec/java-exec/src/test/resources/flatten/complex_transaction_example_data_modified.json
PRE-CREATION 
  exec/java-exec/src/test/resources/flatten/complex_transaction_repeated_map_double_copy_baseline.json
PRE-CREATION 

Diff: https://reviews.apache.org/r/36292/diff/


Testing
-------

Testing in progress, relevent related unit tests are passing


Thanks,

Jason Altekruse


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message