drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Hsuan-Yi Chu" <hsua...@usc.edu>
Subject Re: Review Request 36219: DRILL-3292: SUM(constant) OVER(...) returns wrong results
Date Tue, 07 Jul 2015 21:27:54 GMT


> On July 7, 2015, 1:43 p.m., Aman Sinha wrote:
> > exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java, line
408
> > <https://reviews.apache.org/r/36219/diff/2/?file=1000522#file1000522line408>
> >
> >     Pls modify this test case to have both constants and non-constant window aggregates
as well as a rank() function since the creation of the Drill logical expression is sensitive
to the indexes.

You can see the new patch to see if that one is good.

BTW, the baseline is constructed by Postgres.


- Sean Hsuan-Yi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36219/#review90700
-----------------------------------------------------------


On July 6, 2015, 9:23 p.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36219/
> -----------------------------------------------------------
> 
> (Updated July 6, 2015, 9:23 p.m.)
> 
> 
> Review request for drill, abdelhakim deneche and Aman Sinha.
> 
> 
> Bugs: DRILL-3292
>     https://issues.apache.org/jira/browse/DRILL-3292
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> At the stage of converting Prel to Pop (planning phase), ensure constants in Window are
converted to LogicalExpression
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrel.java
170438e 
>   exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java 8676c28

> 
> Diff: https://reviews.apache.org/r/36219/diff/
> 
> 
> Testing
> -------
> 
> unit, tpch, functional
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message