drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sudheesh Katkam" <skat...@maprtech.com>
Subject Re: Review Request 36168: DRILL-3167: When a query fails, Foreman should wait for all fragments to finish cleaning up before sending a FAILED state to the client
Date Tue, 07 Jul 2015 17:02:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36168/#review90724
-----------------------------------------------------------


Please add unit tests to ensure the behavior is as expected. Although you are making the change
to fix a specific issue, it is a change in the state machine and this can introduce issues
(and in the past, you have chased some of these too).

I can think of one: pause on one drillbit, fail on another, resume the pause and ensure you
get the state *after* the resume.

- Sudheesh Katkam


On July 3, 2015, 4:13 p.m., abdelhakim deneche wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36168/
> -----------------------------------------------------------
> 
> (Updated July 3, 2015, 4:13 p.m.)
> 
> 
> Review request for drill, Jacques Nadeau and Sudheesh Katkam.
> 
> 
> Bugs: DRILL-3167
>     https://issues.apache.org/jira/browse/DRILL-3167
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> when a query fails Foreman moves to a FAILING state until all fragment return a terminal
state. The Web UI will still display FAILED instead of FAILING
> 
> TestDrillbitResilience#failsWhenSendingFragments exposes a limitation to this approach:
if an error occurs when setting up remote fragments we can't assume they will be able to return
a terminal state. In this case the Foreman will not wait for them to finish and return FAILED
to the client immediately.
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
6656bf6 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java
dd26a76 
>   exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 716fb66

>   exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java 9318233

>   exec/java-exec/src/main/resources/rest/profile/list.ftl cf92ede 
>   exec/java-exec/src/main/resources/rest/profile/profile.ftl 46cdc83 
>   exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java
ce09f68 
>   protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java e76d748 
>   protocol/src/main/java/org/apache/drill/exec/proto/beans/QueryResult.java 474e330 
>   protocol/src/main/protobuf/UserBitShared.proto 0451fd2 
> 
> Diff: https://reviews.apache.org/r/36168/diff/
> 
> 
> Testing
> -------
> 
> unit tests are passing along with customer and tpch100
> 
> 
> Thanks,
> 
> abdelhakim deneche
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message