drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdelhakim deneche" <adene...@gmail.com>
Subject Re: Review Request 36219: DRILL-3292: SUM(constant) OVER(...) returns wrong results
Date Mon, 06 Jul 2015 21:33:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36219/#review90577
-----------------------------------------------------------


+1 (non binding)

- abdelhakim deneche


On July 6, 2015, 9:23 p.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36219/
> -----------------------------------------------------------
> 
> (Updated July 6, 2015, 9:23 p.m.)
> 
> 
> Review request for drill, abdelhakim deneche and Aman Sinha.
> 
> 
> Bugs: DRILL-3292
>     https://issues.apache.org/jira/browse/DRILL-3292
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> At the stage of converting Prel to Pop (planning phase), ensure constants in Window are
converted to LogicalExpression
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrel.java
170438e 
>   exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java 8676c28

> 
> Diff: https://reviews.apache.org/r/36219/diff/
> 
> 
> Testing
> -------
> 
> unit, tpch, functional
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message