drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdelhakim deneche" <adene...@gmail.com>
Subject Re: Review Request 36208: DRILL-3455: If a drillbit, that contains fragments for the current query, dies the QueryManager will fail the query even if those fragments already finished successfully
Date Mon, 06 Jul 2015 19:42:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36208/#review90541
-----------------------------------------------------------


+1 (non-binding)

- abdelhakim deneche


On July 6, 2015, 6:47 p.m., Sudheesh Katkam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36208/
> -----------------------------------------------------------
> 
> (Updated July 6, 2015, 6:47 p.m.)
> 
> 
> Review request for drill, abdelhakim deneche and Jacques Nadeau.
> 
> 
> Bugs: DRILL-3455
>     https://issues.apache.org/jira/browse/DRILL-3455
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> DRILL-3455: If fragments on unregistered Drillbits finished successfully, do not fail
the query
> 
> + DRILL-3448: Flipped the atLeastOneFailure condition in QueryManager
> + fixes in DrillbitStatusListener interface
> + logs from implementations of DrillbitStatusListener
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/DrillbitStatusListener.java
80f2ca1 
>   exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java 9318233

> 
> Diff: https://reviews.apache.org/r/36208/diff/
> 
> 
> Testing
> -------
> 
> passes unit tests
> 
> 
> Thanks,
> 
> Sudheesh Katkam
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message