drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sudheesh Katkam" <skat...@maprtech.com>
Subject Review Request 36210: DRILL-3341: Move OperatorWrapper list and FragmentWrapper list creation to ProfileWrapper ctor
Date Mon, 06 Jul 2015 17:15:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36210/
-----------------------------------------------------------

Review request for drill and Jason Altekruse.


Bugs: DRILL-3341
    https://issues.apache.org/jira/browse/DRILL-3341


Repository: drill-git


Description
-------

DRILL-3341: Avoid recomputing stats in ProfileWrapper
+ Small optimizations and comments in OperatorWrapper and FragmentWrapper
+ Comparator renames for consistency
+ Move TableBuilder#toString logic to TableBuilder#build
+ Incorrect field names in profile page for failed queries


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/Comparators.java
20f76a2 
  exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
e395e3e 
  exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
403a23f 
  exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java
dd26a76 
  exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java
8616820 
  exec/java-exec/src/main/resources/rest/profile/profile.ftl 46cdc83 

Diff: https://reviews.apache.org/r/36210/diff/


Testing
-------

will update


Thanks,

Sudheesh Katkam


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message