drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdelhakim deneche" <adene...@gmail.com>
Subject Re: Review Request 36103: DRILL-3445: BufferAllocator.buffer() implementations should throw an OutOfMemoryRuntimeException
Date Fri, 03 Jul 2015 15:08:27 GMT


> On July 1, 2015, 9:44 p.m., Hanifi Gunes wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/record/selection/SelectionVector2.java,
line 94
> > <https://reviews.apache.org/r/36103/diff/1/?file=997588#file997588line94>
> >
> >     Not a show stopper but I would suggest renaming this to allocateNewSafe, following
conventions in the rest of codebase.
> 
> Jacques Nadeau wrote:
>     I mean mean limit.  Best if also suggested what limit we hit (operator, query, system).
>     
>     For example, we're constrained to 20mb for this operator allocator and we fail to
allocate because we're at 10mb and just asked for a 50mb allocation.
> 
> abdelhakim deneche wrote:
>     I'm still not sure how to find which limit we did hit, at least with the "current"
allocator
> 
> abdelhakim deneche wrote:
>     @hanifi, when I renamed allocateNew -> allocateNewSafe I noticed 2 places where
the code doesn't check if the allocation was sucessful or not. Should I fix both places as
part of this patch ?

will fix as part of my next patch


- abdelhakim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36103/#review90137
-----------------------------------------------------------


On July 3, 2015, 2:37 p.m., abdelhakim deneche wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36103/
> -----------------------------------------------------------
> 
> (Updated July 3, 2015, 2:37 p.m.)
> 
> 
> Review request for drill, Chris Westin and Hanifi Gunes.
> 
> 
> Bugs: DRILL-3445
>     https://issues.apache.org/jira/browse/DRILL-3445
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> BufferAllocator.buffer(int) implementations throw an OutOfMemoryRuntimeException instead
of returning null.
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/codegen/templates/FixedValueVectors.java 7103a17 
>   exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java 50ae770 
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorAccessibleSerializable.java
016cd92 
>   exec/java-exec/src/main/java/org/apache/drill/exec/memory/BufferAllocator.java 811cceb

>   exec/java-exec/src/main/java/org/apache/drill/exec/memory/TopLevelAllocator.java b4386a4

>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/filter/FilterTemplate2.java
cd2fbe9 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/limit/LimitRecordBatch.java
d9330ea 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
6da5582 
>   exec/java-exec/src/main/java/org/apache/drill/exec/record/selection/SelectionVector2.java
7a7c012 
>   exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ProtobufLengthDecoder.java 4e03f11

>   exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetDirectByteBufferAllocator.java
cf30db6 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java 10bdf07 
>   exec/java-exec/src/main/java/parquet/hadoop/ColumnChunkIncReadStore.java 6337d4c 
>   exec/java-exec/src/test/java/org/apache/drill/TestAllocationException.java 051ad4e

>   exec/java-exec/src/test/java/org/apache/drill/exec/memory/TestAllocators.java 74ce225

> 
> Diff: https://reviews.apache.org/r/36103/diff/
> 
> 
> Testing
> -------
> 
> testing...
> 
> 
> Thanks,
> 
> abdelhakim deneche
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message