drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Nadeau" <jacques.dr...@gmail.com>
Subject Re: Review Request 36103: DRILL-3445: BufferAllocator.buffer() implementations should throw an OutOfMemoryRuntimeException
Date Thu, 02 Jul 2015 20:29:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36103/#review90278
-----------------------------------------------------------



exec/java-exec/src/main/java/org/apache/drill/exec/memory/TopLevelAllocator.java (line 96)
<https://reviews.apache.org/r/36103/#comment143281>

    We should probably move this exception inside of reserve.  Then we can know which accountor.
 This means that we need to label the allocators when we get them.  That being said, let's
hold on this until we get Chris's new allocator merged.  You want to open a separate bug to
add better out of memory exceptions?  Maybe for now just add information about what was the
allocation size when we failed.


- Jacques Nadeau


On July 1, 2015, 9:21 p.m., abdelhakim deneche wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36103/
> -----------------------------------------------------------
> 
> (Updated July 1, 2015, 9:21 p.m.)
> 
> 
> Review request for drill, Chris Westin and Hanifi Gunes.
> 
> 
> Bugs: DRILL-3445
>     https://issues.apache.org/jira/browse/DRILL-3445
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> BufferAllocator.buffer(int) implementations throw an OutOfMemoryRuntimeException instead
of returning null.
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/codegen/templates/FixedValueVectors.java 7103a17 
>   exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java 50ae770 
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorAccessibleSerializable.java
016cd92 
>   exec/java-exec/src/main/java/org/apache/drill/exec/memory/BufferAllocator.java 811cceb

>   exec/java-exec/src/main/java/org/apache/drill/exec/memory/TopLevelAllocator.java b4386a4

>   exec/java-exec/src/main/java/org/apache/drill/exec/record/selection/SelectionVector2.java
7a7c012 
>   exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ProtobufLengthDecoder.java 4e03f11

>   exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetDirectByteBufferAllocator.java
cf30db6 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java 10bdf07 
>   exec/java-exec/src/main/java/parquet/hadoop/ColumnChunkIncReadStore.java 6337d4c 
>   exec/java-exec/src/test/java/org/apache/drill/TestAllocationException.java 051ad4e

>   exec/java-exec/src/test/java/org/apache/drill/exec/memory/TestAllocators.java 74ce225

> 
> Diff: https://reviews.apache.org/r/36103/diff/
> 
> 
> Testing
> -------
> 
> unit tests are passing, along with functional and tpch100
> 
> 
> Thanks,
> 
> abdelhakim deneche
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message