drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hanifi Gunes" <hanifigu...@gmail.com>
Subject Re: Review Request 36070: DRILL-3243: Need a better error message - Use of alias in window function definition
Date Thu, 02 Jul 2015 05:14:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36070/#review90194
-----------------------------------------------------------

Ship it!


- Hanifi Gunes


On June 30, 2015, 11:20 p.m., abdelhakim deneche wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36070/
> -----------------------------------------------------------
> 
> (Updated June 30, 2015, 11:20 p.m.)
> 
> 
> Review request for drill and Hanifi Gunes.
> 
> 
> Bugs: DRILL-3243
>     https://issues.apache.org/jira/browse/DRILL-3243
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> improved error message and added a unit test
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/drill/common/exceptions/UserException.java 13c17bd

>   common/src/main/java/org/apache/drill/common/exceptions/UserRemoteException.java 1b3fa42

>   exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/CompliantTextRecordReader.java
254e0d8 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/RepeatedVarCharOutput.java
40276f4 
>   exec/java-exec/src/test/java/org/apache/drill/exec/store/text/TestNewTextReader.java
76674f9 
> 
> Diff: https://reviews.apache.org/r/36070/diff/
> 
> 
> Testing
> -------
> 
> all unit tests are passing along with functional and tpch100
> 
> 
> Thanks,
> 
> abdelhakim deneche
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message