Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Received-SPF: pass (nike.apache.org: domain of adeneche@maprtech.com
 designates 209.85.160.177 as permitted sender)
MIME-Version: 1.0
Date: Tue, 30 Jun 2015 12:06:31 -0700
Message-ID: 
 <CAKTYAC_k3VYw4eWZxifraaqMyf-_d=2h71eLrSOWfGE=CDeeSg@mail.gmail.com>
Subject: [DISCUSSION] should BufferAllocator.buffer() throw an
 OutOfMemoryException ?
From: Abdel Hakim Deneche <adeneche@maprtech.com>
To: "dev@drill.apache.org" <dev@drill.apache.org>
Content-Type: multipart/alternative; boundary=001a113a724273b3c60519c0e7ca

--001a113a724273b3c60519c0e7ca
Content-Type: text/plain; charset=UTF-8

our current implementations of BufferAllocator.buffer(int, int) returns
null when it cannot allocate the buffer.

But looking through the code, there are many places that don't check if the
allocated buffer is null before trying to access it which will throw a
NullPointerException.

ValueVectors' allocateNewSafe() seem to be the only place that handle the
null in a specific manner.

Should we update the allocators' implementation to throw an
OutOfMemoryRuntimeException instead of returning null ? this has the added
benefit of displaying a proper out of memory error message to the user.

Thanks!

-- 

Abdelhakim Deneche

Software Engineer

  <http://www.mapr.com/>


Now Available - Free Hadoop On-Demand Training
<http://www.mapr.com/training?utm_source=Email&utm_medium=Signature&utm_campaign=Free%20available>

--001a113a724273b3c60519c0e7ca--