Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1B2EC175BC for ; Wed, 24 Jun 2015 22:31:14 +0000 (UTC) Received: (qmail 34824 invoked by uid 500); 24 Jun 2015 22:31:13 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 34772 invoked by uid 500); 24 Jun 2015 22:31:13 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 34761 invoked by uid 500); 24 Jun 2015 22:31:13 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 34753 invoked by uid 99); 24 Jun 2015 22:31:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Jun 2015 22:31:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A523EA9E6B; Wed, 24 Jun 2015 22:31:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4509103018641574765==" MIME-Version: 1.0 Subject: Re: Review Request 34690: DRILL-2903 Update TestDrillbitResilience tests so that they correctly manage canceled queries that get to complete too quickly From: "Parth Chandra" To: "Venki Korukanti" , "Chris Westin" , "abdelhakim deneche" Cc: "drill" , "Sudheesh Katkam" , "Parth Chandra" Date: Wed, 24 Jun 2015 22:31:12 -0000 Message-ID: <20150624223112.3114.38321@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Parth Chandra" X-ReviewGroup: drill-git X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/34690/ X-Sender: "Parth Chandra" References: <20150529235223.8660.75626@reviews.apache.org> In-Reply-To: <20150529235223.8660.75626@reviews.apache.org> Reply-To: "Parth Chandra" X-ReviewRequest-Repository: drill-git --===============4509103018641574765== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34690/#review89266 ----------------------------------------------------------- Ship it! Ship It! - Parth Chandra On May 29, 2015, 11:52 p.m., Sudheesh Katkam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34690/ > ----------------------------------------------------------- > > (Updated May 29, 2015, 11:52 p.m.) > > > Review request for drill, abdelhakim deneche, Chris Westin, and Venki Korukanti. > > > Bugs: DRILL-2903 > https://issues.apache.org/jira/browse/DRILL-2903 > > > Repository: drill-git > > > Description > ------- > > DRILL-2903: General improvements to tests in TestDrillbitResilience > + Added RepeatTestRule to tests that are flaky > + Added Controls.Builder to create controls string in tests > + Added @Ignore to failing tests (filed JIRAs) > > Other fixes: > + Added @Override to ScanBatch#close to avoid potential bugs > + Added docs link in ProtobufLengthDecoder > + Fixed logging issue in CountDownLatchImpl > > > Diffs > ----- > > common/src/main/java/org/apache/drill/common/util/RepeatTestRule.java PRE-CREATION > common/src/main/java/org/apache/drill/common/util/TestTools.java 5be8d40 > common/src/test/java/org/apache/drill/test/DrillTest.java bbe014f > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java 6176f77 > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ProtobufLengthDecoder.java 4f075d3 > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlTunnel.java 16b9b63 > exec/java-exec/src/main/java/org/apache/drill/exec/testing/CountDownLatchInjectionImpl.java 561d816 > exec/java-exec/src/main/java/org/apache/drill/exec/testing/ExecutionControls.java 639802f > exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/ControlMessageHandler.java 8ee7d38 > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 5d07b49 > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java 71b77c6 > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java e5e0700 > exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java 696aed8 > exec/java-exec/src/test/java/org/apache/drill/exec/testing/Controls.java PRE-CREATION > exec/java-exec/src/test/java/org/apache/drill/exec/testing/ControlsInjectionUtil.java 346c6dd > exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestCountDownLatchInjection.java c98f54c > exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestExceptionInjection.java e3558a1 > exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestPauseInjection.java ba29c58 > > Diff: https://reviews.apache.org/r/34690/diff/ > > > Testing > ------- > > Unit tests pass on Linux, and successful regression tests. > > > Thanks, > > Sudheesh Katkam > > --===============4509103018641574765==--