Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 928B918D52 for ; Tue, 23 Jun 2015 23:41:38 +0000 (UTC) Received: (qmail 51745 invoked by uid 500); 23 Jun 2015 23:41:38 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 51683 invoked by uid 500); 23 Jun 2015 23:41:38 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 51672 invoked by uid 500); 23 Jun 2015 23:41:38 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 51666 invoked by uid 99); 23 Jun 2015 23:41:38 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Jun 2015 23:41:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 50E7AA9C0F; Tue, 23 Jun 2015 23:41:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7905770752209065132==" MIME-Version: 1.0 Subject: Re: Review Request 35484: DRILL-2851: set an upper-bound on # of bytes to re-allocate to prevent overflows From: "Jason Altekruse" To: "Mehant Baid" , "Jason Altekruse" Cc: "Hanifi Gunes" , "drill" Date: Tue, 23 Jun 2015 23:41:37 -0000 Message-ID: <20150623234137.3114.74370@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jason Altekruse" X-ReviewGroup: drill-git X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/35484/ X-Sender: "Jason Altekruse" References: <20150623225903.3113.66090@reviews.apache.org> In-Reply-To: <20150623225903.3113.66090@reviews.apache.org> Reply-To: "Jason Altekruse" X-ReviewRequest-Repository: drill-git --===============7905770752209065132== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35484/#review89076 ----------------------------------------------------------- Ship it! exec/java-exec/src/main/codegen/templates/NullableValueVectors.java (line 134) If the allocation of the bit vector fails will this cause issues calling zeroVector on an unallocated vector? I think there is a risk that we will have a null buffer that the old code would defend against, the zeroVector() method calls a method on the data buffer directly. We need to add a return false after the clear in the finally block. exec/java-exec/src/main/codegen/templates/NullableValueVectors.java (line 216) Same as above - Jason Altekruse On June 23, 2015, 10:59 p.m., Hanifi Gunes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35484/ > ----------------------------------------------------------- > > (Updated June 23, 2015, 10:59 p.m.) > > > Review request for drill, Jason Altekruse and Mehant Baid. > > > Repository: drill-git > > > Description > ------- > > DRILL-2851: set an upper-bound on # of bytes to re-allocate to prevent overflows > Vectors > - set an upper bound on # of bytes to allocate > - > TestValueVector.java > - Add unit tests > > > Diffs > ----- > > exec/java-exec/src/main/codegen/includes/vv_imports.ftl 92c80072cfcde4deb0bbb34bc3b688707541f2f6 > exec/java-exec/src/main/codegen/templates/FixedValueVectors.java 7103a17108693d47839212c418d11d13fbb8f6f4 > exec/java-exec/src/main/codegen/templates/NullableValueVectors.java 7f835424b68a9d68b0a6c60749677a83ac486590 > exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java 50ae770f24aff1e8eed1dfa800878ce92308c644 > exec/java-exec/src/main/java/org/apache/drill/exec/exception/OversizedAllocationException.java PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java 999140498ab303d3f5ecf20695755bdfe943cb46 > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenTemplate.java de67b62248a68c1f483808c4b575e0afa7854aca > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/Flattener.java 92cf79d37da89864ab7702830fe078479773a73e > exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseDataValueVector.java 0e38f3cad3792e936ff918ae970f4b40e478d516 > exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseValueVector.java 8129668b6ff5dc674e30dca6947bd93c87fb4d3d > exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java 10bdf0752632c7577b9a6eb445c7101ec1a24730 > exec/java-exec/src/test/java/org/apache/drill/exec/record/vector/TestValueVector.java 037c8c6d3da94acf5c2ca300ce617338cacb0fb0 > > Diff: https://reviews.apache.org/r/35484/diff/ > > > Testing > ------- > > all > > > Thanks, > > Hanifi Gunes > > --===============7905770752209065132==--