Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Content-Type: multipart/alternative;
 boundary="===============2332340630174509490=="
MIME-Version: 1.0
Subject: Re: Review Request 35636: DRILL-2447: Add already-closed checks to
 remaining ResultSet methods.
From: "Hanifi Gunes" <hanifigunes@gmail.com>
To: "Mehant Baid" <baid.mehant@gmail.com>,
 "Hanifi Gunes" <hanifigunes@gmail.com>
Cc: "drill" <drill-dev@incubator.apache.org>,
 "Daniel Barclay" <dbarclay@maprtech.com>
Date: Tue, 23 Jun 2015 19:24:35 -0000
Message-ID: <20150623192435.20383.75181@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Hanifi Gunes" <noreply@reviews.apache.org>
References: <20150619202314.1515.53262@reviews.apache.org>
In-Reply-To: <20150619202314.1515.53262@reviews.apache.org>
Reply-To: "Hanifi Gunes" <hanifigunes@gmail.com>

--===============2332340630174509490==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35636/#review89033
-----------------------------------------------------------

Ship it!


looks good except one minor comment below.


exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java (line 382)
<https://reviews.apache.org/r/35636/#comment141638>

    Do we really need to have these comments checked-in? These look extensive.


- Hanifi Gunes


On June 19, 2015, 8:23 p.m., Daniel Barclay wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35636/
> -----------------------------------------------------------
> 
> (Updated June 19, 2015, 8:23 p.m.)
> 
> 
> Review request for drill, Hanifi Gunes and Mehant Baid.
> 
> 
> Bugs: DRILL-2447
>     https://issues.apache.org/jira/browse/DRILL-2447
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Extended coverage from just selected methods to all methods.  Added wrapper
> methods checking state before delegating.  (Couldn't implement at just a few
> choke points because Avatica makes them private and doesn't provide hooks.)
> [DrillResultSetImpl]
> 
> Defined DrillResultSet.getQueryId() to throw SQLException as other methods do.
> [DrillResultSet]
> 
> Re-enabled ResultSet test methods.  (Also re-enabled other test methods that
> pass now with DRILL-2782 changes.  [Drill2489CallsAfterCloseThrowExceptionsTest]
> 
> 
> Diffs
> -----
> 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java e0a7763 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java d7fafe9 
>   exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2489CallsAfterCloseThrowExceptionsTest.java 0e37efa 
> 
> Diff: https://reviews.apache.org/r/35636/diff/
> 
> 
> Testing
> -------
> 
> Enabled pre-written specific unit tests.
> 
> Ran existing tests; no new failures.
> 
> 
> Thanks,
> 
> Daniel Barclay
> 
>


--===============2332340630174509490==--