Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 40D23172F4 for ; Thu, 18 Jun 2015 06:37:27 +0000 (UTC) Received: (qmail 76686 invoked by uid 500); 18 Jun 2015 06:37:27 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 76641 invoked by uid 500); 18 Jun 2015 06:37:27 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 76630 invoked by uid 500); 18 Jun 2015 06:37:26 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 76624 invoked by uid 99); 18 Jun 2015 06:37:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Jun 2015 06:37:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 536B41DFFFE; Thu, 18 Jun 2015 06:37:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1631590593874606335==" MIME-Version: 1.0 Subject: Re: Review Request 35417: DRILL-3285: Part 5--Split old hacky next() into separate methods. From: "Daniel Barclay" To: "abdelhakim deneche" Cc: "Daniel Barclay" , "Parth Chandra" , "drill" Date: Thu, 18 Jun 2015 06:37:26 -0000 Message-ID: <20150618063726.1512.24379@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Daniel Barclay" X-ReviewGroup: drill-git X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/35417/ X-Sender: "Daniel Barclay" References: <20150617170651.1515.99280@reviews.apache.org> In-Reply-To: <20150617170651.1515.99280@reviews.apache.org> Reply-To: "Daniel Barclay" X-ReviewRequest-Repository: drill-git --===============1631590593874606335== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35417/ ----------------------------------------------------------- (Updated June 18, 2015, 6:37 a.m.) Review request for drill and abdelhakim deneche. Bugs: DRILL-3285 https://issues.apache.org/jira/browse/DRILL-3285 Repository: drill-git Description ------- Split the original public next() method (which was hacked to handle an extra, initial call to read the schema batch) into: - new loadInitialSchema() (for handling the call for the schema) - modified next() (for handling normal calls from ResultSet.next()) - new private nextRowInternally() (for common code) Pulled invariant afterFirstBatch up out of bogus-batch loop. Diffs (updated) ----- exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java PRE-CREATION exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java cb6bd1d Diff: https://reviews.apache.org/r/35417/diff/ Testing ------- Ran tests (all parts together); no new errors. Thanks, Daniel Barclay --===============1631590593874606335==--