Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 16FC7179CB for ; Tue, 16 Jun 2015 01:47:31 +0000 (UTC) Received: (qmail 54920 invoked by uid 500); 16 Jun 2015 01:47:30 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 54868 invoked by uid 500); 16 Jun 2015 01:47:30 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 54857 invoked by uid 500); 16 Jun 2015 01:47:30 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 54851 invoked by uid 99); 16 Jun 2015 01:47:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jun 2015 01:47:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 02F701DFE5F; Tue, 16 Jun 2015 01:47:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1126738422276420646==" MIME-Version: 1.0 Subject: Re: Review Request 35052: DRILL-2089: Part 7--Post-move hygiene (simplification, renaming, whitespace). From: "Daniel Barclay" To: "Mehant Baid" , "Parth Chandra" Cc: "drill" , "Daniel Barclay" Date: Tue, 16 Jun 2015 01:47:30 -0000 Message-ID: <20150616014730.32040.45267@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Daniel Barclay" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/35052/ X-Sender: "Daniel Barclay" References: <20150610190526.27736.84782@reviews.apache.org> In-Reply-To: <20150610190526.27736.84782@reviews.apache.org> Reply-To: "Daniel Barclay" X-ReviewRequest-Repository: drill-git --===============1126738422276420646== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35052/ ----------------------------------------------------------- (Updated June 16, 2015, 1:47 a.m.) Review request for drill, Mehant Baid and Parth Chandra. Changes ------- Re-uploading patches, trying to fix/work around Review Board empty-files problem. Bugs: DRILL-2089 https://issues.apache.org/jira/browse/DRILL-2089 Repository: drill-git Description ------- Fixed "cleanup()" to "cleanUp()". [DrillRemoteStatement, DrillPreparedStatement, DrillStatementImpl, DrillHandler] Renamed DrillConnection.config() to more conventional getConfig(). [DrillConnection, DrillConnectionImpl] Removed now-unneeded "abstract" and eliminated now-unneeded subclasses. [DrillConnectionImpl, DrillStatementImpl, DrillJdbc41Factory] Simplified boolean Driver.load() to void. [Driver] - Switched from "new Driver()" to "Driver.load()" in one case. [ConnectionTest] Fixed "Optiq" -> "Drill", cleaned up createDriverVersion. [DriverImpl] Adjusted unknown-case handling, logging. [DrillColumnMetaDataList] Wrapped lines; adjusted other whitespace. Diffs (updated) ----- exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnection.java d64f980 exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillColumnMetaDataList.java PRE-CREATION exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java PRE-CREATION exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillFactory.java PRE-CREATION exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillHandler.java PRE-CREATION exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java PRE-CREATION exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillRemoteStatement.java PRE-CREATION exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java cb6bd1d exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java 6610f52 exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DriverImpl.java PRE-CREATION exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionTest.java 8a469c3 Diff: https://reviews.apache.org/r/35052/diff/ Testing ------- Ran existing tests. (With parts 1 through 7 together.) Thanks, Daniel Barclay --===============1126738422276420646==--