Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E51061723C for ; Thu, 11 Jun 2015 21:46:40 +0000 (UTC) Received: (qmail 5064 invoked by uid 500); 11 Jun 2015 21:46:35 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 5015 invoked by uid 500); 11 Jun 2015 21:46:35 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 5004 invoked by uid 500); 11 Jun 2015 21:46:35 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 4998 invoked by uid 99); 11 Jun 2015 21:46:35 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jun 2015 21:46:35 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2642A1DFC1F; Thu, 11 Jun 2015 21:46:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0939392943222665372==" MIME-Version: 1.0 Subject: Re: Review Request 35163: DRILL-1169: Add support for UNION (distinct type) From: "Aman Sinha" To: "Aman Sinha" , "Jinfeng Ni" Cc: "Sean Hsuan-Yi Chu" , "drill" Date: Thu, 11 Jun 2015 21:46:35 -0000 Message-ID: <20150611214635.1529.74084@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aman Sinha" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/35163/ X-Sender: "Aman Sinha" References: <20150611175638.1530.15121@reviews.apache.org> In-Reply-To: <20150611175638.1530.15121@reviews.apache.org> Reply-To: "Aman Sinha" X-ReviewRequest-Repository: drill-git --===============0939392943222665372== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35163/#review87636 ----------------------------------------------------------- Ship it! Ship It! - Aman Sinha On June 11, 2015, 5:56 p.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35163/ > ----------------------------------------------------------- > > (Updated June 11, 2015, 5:56 p.m.) > > > Review request for drill, Aman Sinha and Jinfeng Ni. > > > Bugs: DRILL-1169 > https://issues.apache.org/jira/browse/DRILL-1169 > > > Repository: drill-git > > > Description > ------- > > Use Union-All followed by Aggregate to implement Union-Distinct > > > Diffs > ----- > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java 655ad92 > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillUnionAllRule.java PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillUnionRel.java 566c558 > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillUnionRule.java e0f9e2d > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java b92de3b > exec/java-exec/src/test/java/org/apache/drill/TestDisabledFunctionality.java adbf653 > exec/java-exec/src/test/java/org/apache/drill/TestUnionDistinct.java PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q1.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q10.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q11.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q12.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q13.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q14.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q15.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q16.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q17.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_1.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_2.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_3.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q2.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q3.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q4.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q5.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q6.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q6_1.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q7.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q8.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q9.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testAggregationOnUnionDistinctOperator_1.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testAggregationOnUnionDistinctOperator_2.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectDownOverUnionDistinctImplicitCasting.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectFiltertPushDownOverUnionDistinct.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownOverUnionDistinctWithProject.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownOverUnionDistinctWithoutProject.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownProjectColumnReorderingAndAlias.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectWithExpressionPushDownOverUnionDistinct.tsv PRE-CREATION > > Diff: https://reviews.apache.org/r/35163/diff/ > > > Testing > ------- > > all the required tests > > > Thanks, > > Sean Hsuan-Yi Chu > > --===============0939392943222665372==--